Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: console warnings #1240

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: console warnings #1240

wants to merge 1 commit into from

Conversation

chaofan232
Copy link
Contributor

@chaofan232 chaofan232 commented Oct 27, 2021

Description

Does this PR introduce a breaking change?

  • Yes
  • No

Manual testing step?

Screenshots (if appropriate):

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #1240 (73f2ea4) into master (331576d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1240   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           93        93           
  Lines         1377      1377           
  Branches       344       344           
=========================================
  Hits          1377      1377           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 331576d...73f2ea4. Read the comment docs.

@@ -4,16 +4,17 @@ import DesignNotes from '../containers/DesignNotes.jsx';
## User List Picker

```jsx live=true
const avatarColor = (user) => (user.avatar ? '' : 'cyan');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The returned value is used as color props for Avatar component.
So, this method must return one of ['blue', 'green', 'red', 'orange', 'cyan', 'black'].

And as default if there is an image for Avatar component. the color will be not applied.
I just made another example to show how to use avatarColor() method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants